blab / ncov-forecasting-fit

Assessing accuracy of fitness model forecasts
1 stars 2 forks source link

Frequency rather than proportion #15

Closed trvrb closed 1 year ago

trvrb commented 1 year ago

When you reference absolute error, either in the text or in a figure or table, please use frequency (eg 10%) rather than proportion (eg 0.1). Right now in Table 1 it's hard to immediately know whether the top left entry is supposed to be 0.9% or 0.009%. For this, please update:

trvrb commented 1 year ago

This was successfully completed for everything except Figure 4. Please update Var_of_interest.png to use frequency rather than proportion on all 5 panels.

trvrb commented 1 year ago

This was successfully completed for everything except Figure 4. Please update Var_of_interest.png to use frequency rather than proportion on all 5 panels.

trvrb commented 1 year ago

Also, while you're fixing this, please update the y-axis label of Figure from "Mean absolute error" to "Absolute error".

Eabousam commented 1 year ago

Pushed updated and reran figure with frequencies and updated label