blabaere / scaproust

Implementation of the nanomsg "Scalability Protocols" in rust.
Apache License 2.0
192 stars 9 forks source link

There are failing tests on Windows #1

Closed notriddle closed 7 years ago

notriddle commented 7 years ago

They've been failing for awhile now. https://ci.appveyor.com/project/blabaere/scaproust/build/1.0.403

blabaere commented 7 years ago

Hi,

Thanks for your interest and the notification. I did notice the appveyor build status when it broke last week. I'm currently refactoring the socket readiness observer system in order to implement a polling feature and some breakage on device tests is something that I expected.

The good news is that I'm not going to ignore these broken tests. The bad news is:

So it will take time, but it will be fixed.

Regards, Benoît

blabaere commented 7 years ago

@notriddle The appveyor build passes with mio 0.6.0 instead of 0.6.1 so I'll file an issue.

blabaere commented 7 years ago

One of the mio authors has provided an explanation of the problem and a fix idea. Applying it did fix the problem so I'll close the issue for now.