search

blaberry / FullscreenLock

Like AKADEVILs PrimaryLock, but different.
GNU Lesser General Public License v3.0
92 stars 16 forks source link

Simple refactoring #4

Closed cornelha closed 6 years ago

cornelha commented 6 years ago

I did a bit of refactoring to help you address this commend "// One day I'll figure out how to set the label without sending a reference into the constructor." by using an interface which can be passed along instead of a control.

I also moved stuff around a little to make it a bit more manageable. Using names like "l" for label etc makes it a bit tricky to find stuff when you decide to grow this project.

Have fun :)

blaberry commented 6 years ago

Putting the part of the code doing the actual work into a file called "MainFormController" is an abomination. The code follows good practice but this signifies wanting to do the right thing, not making it easy to use.

cornelha commented 6 years ago

Cool, figured I would help pointing you in the right direction :)