blabla1337 / skf-flask

Security Knowledge Framework (SKF) Python Flask / Angular project
https://www.securityknowledgeframework.org
Apache License 2.0
805 stars 308 forks source link

SKF_Login option removal #727

Closed telekomancer closed 2 years ago

telekomancer commented 3 years ago

I guess that could be a very good option, to remove the "Skip Login" button in case that the SKF could be exposed to the internet do a different reasons related to infrastructure or networking desitions. So i guess that could exist and option on environment parameters that could allow that, for example:

environment:
...
- SKIP_LOGIN: "False"
...

So that could give you the option to avoid or skip login, button itself isn't so important, i see that button calls the API on URL: http://localhost/api/user/skipthat, generate an Authorization Token, so the option on environment, probably should delete the authorization token or something like that.

With the False or True Flags i mean that:

blabla1337 commented 2 years ago
  1. By default, the login will be skipped when using docker compose locally. To change this, update the value of SKIP_LOGIN to skfprovider in docker-compose.yml.
blabla1337 commented 2 years ago

Implemented, closing ticket