blabla1337 / skf-flask

Security Knowledge Framework (SKF) Python Flask / Angular project
https://www.securityknowledgeframework.org
Apache License 2.0
810 stars 308 forks source link

Existing features missing #752

Closed timurozkul closed 2 years ago

timurozkul commented 2 years ago

I have tried running it locally on Docker. But it seems there are quite a few features missing such create project, update requirements, etc. I have logged in as admin following this link (https://skf.readme.io/docs/first-run), i assume i am admin but there is no indication. I have noticed that these features exist by looking at the source code but I cannot see them enabled on the application.

github-actions[bot] commented 2 years ago

Thank you for creating an issue ticket for our SKF project, we highly appriciate the feedback so we can improve the project and make it more awesome for everyone! We will shortly come back to you after the evaluation of the issue.

timurozkul commented 2 years ago

I noticed through Brup that the application does auto skip login (automatically redirects) so once a admin is created it auto logs you into the application but not as admin. In other words once the button on admin creation is clicked, the next thing that happens is you get logged in as non admin. I would say this is a bug because I am not able to stop this auto login "feature"

lfservin commented 2 years ago

you need to make a couple changes to your docker-compose script to avoid "auto-skipping" log in.

skf-angular has an attribute "environment". Here you want to set SKIP_LOGIN as:

- SKIP_LOGIN=skfprovider

it would then look like this:

  skf-angular:
    container_name: skf-angular_container
    platform: linux/x86_64
    depends_on:
      - "rabbitmq"
      - "nginx"
      - "mysql"
    restart: always
    image: "blabla1337/skf-angular:4.0.2"
    environment:
      - FRONTEND_URI=http://localhost
      - SKIP_LOGIN=skfprovider
JOT85 commented 2 years ago

I've added this to the docs in #753, along with the other doc changes, sorry this wasn't sooner!

By default, the login will be skipped when using docker compose locally. To change this, update the value of SKIP_LOGIN to skfprovider in docker-compose.yml.

blabla1337 commented 2 years ago

Many thanks @JOT85 for your help and the contributions. Will close this issue as its solved.