search

blablacar / dgr

Container build and runtime tool
Apache License 2.0
249 stars 21 forks source link

generalize assumptions about build environment #215

Closed mark-kubacki closed 7 years ago

mark-kubacki commented 7 years ago

The provided scripts have been written with a specific layout and assumptions about how and where binaries are installed in mind. These patches attempt to generalize for slightly different environments.

n0rad commented 7 years ago

I wanted to push gomake to replace current build scripts before going further. Can you please report your changes to gomake.sh instead.

mark-kubacki commented 7 years ago

I will adjust this PR once you're ready, if you like.

A recommendation regarding workflow, if you allow:

It's more polite to accept something and discard it right away due to being obsolete, than creating work to both parties. And, you don't break as many PRs. For example, the authors of openssl had to learn this the hard way (running something like go fmt and angering authors of literally hundreds of contributions).

n0rad commented 7 years ago

You are totally right, but it's not a refacto it's a build toolchain change I wanted to do, before going further (improvement).

That's my fault, I will cherry-pick manually your changes.

mark-kubacki commented 7 years ago

Please don't cherry-pick from this one: I will update this PR with changes to your scripts from today. I just wanted to wait until you are done.

My other PR on the other hand is finalized.

n0rad commented 7 years ago

It's not perfect yet, but it should not change a lot again. You can go ahead. Sorry again

n0rad commented 7 years ago

You don't have to close this PR. Bring those improvement to gomake is interesting.

I just wanted to replace current build scripts with gomake so you don't improve deprecated scripts. You just got faster than me.

n0rad commented 7 years ago

I have forwardport changes to gomake except -u that needs to be done in another commit