search

blachlylab / dhtslib

D bindings and OOP wrappers for htslib
MIT License
7 stars 1 forks source link

Linker postblit fix #123

Closed charlesgregory closed 2 years ago

charlesgregory commented 2 years ago

These changes appear to fix #122. I failed to receive any traction on my question(s) posted on the dlang forums.

In essence, use of SafeHtslibPtr necessitates an explicit postblit unless using ldc version 1.25.0 or greater.

charlesgregory commented 2 years ago

Reminder for me that if we decide to approve/merge this, I need to create a postblit for Genotype if #125 is merged as well.

This does point a large downside of this fix. Postblits must be explicitly made for every type that relies on SafeHtslibPtr. If this is to be the fix for this problem, we need to add the new test case to the github actions tests to make sure the code base is build-able with dmd and prior versions of ldc to ensure "backwards compatibility" of the code base.

jblachly commented 2 years ago

ok to merge