search

blachlylab / dhtslib

D bindings and OOP wrappers for htslib
MIT License
7 stars 1 forks source link

changes to qscore functions #53

Closed charlesgregory closed 4 years ago

charlesgregory commented 4 years ago

This should address #52. unittests pass for sam/package.d now. Any suggestions?

jblachly commented 4 years ago

LGTM. do you think it would be worth having a setter that takes a char array , i.e. something you would read from a FASTQ or SAM record? Wouldn't worry about that now but just keep that in mind if use case ever comes up

jblachly commented 4 years ago

@charlesgregory Also I guess I should have asked even though our unit tests pass here, please triple check FADE, as well as Esko's work , and if you ahve time, swiftover, for any calls to these functions that may need to be checked for implicit template instantiation (since default for one of them was true)

charlesgregory commented 4 years ago

I will do that, fade and swiftover shouldn't be pulling from dhtslib master or develop.