search

blachlylab / dhtslib

D bindings and OOP wrappers for htslib
MIT License
7 stars 1 forks source link

Split dhtslib/sam/package.d #63

Closed charlesgregory closed 3 years ago

charlesgregory commented 3 years ago

Split dhtslib/sam/package.d into one class/struct per file. This will make the file more manageable. It will also help the classes/structs not be separated by lots of unittests.

charlesgregory commented 3 years ago

New structure:

dhtslib/sam/package.d -> dhtslib/sam/package.d    (only public imports and helper functions)
                      -> dhtslib/sam/record.d       SAMRecord
                      -> dhtslib/sam/reader.d       SAMReader
                      -> dhtslib/sam/writer.d       SAMWriter
dhtslib/tagvalue.d    -> dhtslib/sam/tagvalue.d
jblachly commented 3 years ago

Sounds fine, but don't forget that private is module-level, be prepared for breakage. Good reason to get the CI tests fixed before undertaking this change