blachlylab / mucor3

Parses VCF data into tabular spreadsheets and aggregates data by sample
MIT License
0 stars 0 forks source link

Pivot table positive rate wrong denominator #2

Closed jblachly closed 5 years ago

jblachly commented 5 years ago

(See also #1)

Commit 4367c9e3faa6ac1236ac2e42490d62a918abfbb7 introduced positive no. and positive rate in aggregate.pivot. However, main which calls pivot later adds back missing columns (if any). This means the positive rate's denominator is wrong.

Suggest removing it, or refactor positive no. and positive rate into separate functino you can call frmo main after adding back missing columns