black-desk / fcitx5-ui.nvim

fcitx5 user interface inside neovim
GNU General Public License v3.0
40 stars 0 forks source link

It seems that luarocks do not get updated. #14

Closed black-desk closed 3 months ago

black-desk commented 3 months ago

Github action success.

https://github.com/black-desk/fcitx5-ui.nvim/actions/runs/9617057612/job/26527982673

logs_25176468782.zip

But rockspec not get updated.

https://luarocks.org/manifests/black-desk/fcitx5-ui.nvim-scm-1.rockspec

local git_ref = '2612c6cfeb2f31de45a6a7096428ef32f885070e'
local modrev = 'scm'
local specrev = '1'

local repo_url = 'https://github.com/black-desk/fcitx5-ui.nvim'

rockspec_format = '3.0'
package = 'fcitx5-ui.nvim'
version = modrev ..'-'.. specrev

description = {
  summary = 'fcitx5 user interface inside neovim',
  detailed = '',
  labels = { },
  homepage = 'https://github.com/black-desk/fcitx5-ui.nvim',
  license = 'GPL-3.0'
}

dependencies = { 'lua >= 5.1', 'dbus_proxy' } 

test_dependencies = { }

source = {
  url = repo_url .. '/archive/' .. git_ref .. '.zip',
  dir = 'fcitx5-ui.nvim-' .. '2612c6cfeb2f31de45a6a7096428ef32f885070e',
}

if modrev == 'scm' or modrev == 'dev' then
  source = {
    url = repo_url:gsub('https', 'git')
  }
end

build = {
  type = 'builtin',
  copy_directories = { 'doc' } ,
}

So what is going on here?

black-desk commented 3 months ago

@Freed-Wu

Freed-Wu commented 3 months ago

Confused too. Maybe the author of this github action @mrcjkb know it?

mrcjkb commented 3 months ago

You have two options:

Alternatively, you can just create an scm rockspec that has the git repo as the source, and upload it manually, without using luarocks-tag-release. That way there's no need to update it unless the dependencies change. Here's an example.

black-desk commented 3 months ago

You have two options:

  • Increment the specrev (the number after scm-)
  • Add a --force flag, which you can do with extra_luarocks_args input.

@mrcjkb

Should this github actioin failed in this situation?

https://github.com/nvim-neorocks/luarocks-tag-release/blob/bf22420702d8768f0eb5d8148a0fc9d6da1ddc92/lua/luarocks-tag-release.lua#L62

It seems that error is not check here.

Alternatively, you can just create an scm rockspec that has the git repo as the source, and upload it manually, without using luarocks-tag-release. That way there's no need to update it unless the dependencies change. Here's an example.

black-desk commented 3 months ago

Fixed.

mrcjkb commented 3 months ago

Should this github actioin failed in this situation?

No, we have a fail_on_duplicate option that is false by default. The reason is that using this workflow to upload scm rockspecs is an unlikely use case, and we want people to be able to run this action on every commit without it failing if a rock already exists.