black-desk / fcitx5-ui.nvim

fcitx5 user interface inside neovim
GNU General Public License v3.0
39 stars 0 forks source link

feat: release on luarocks #8

Closed Freed-Wu closed 1 month ago

Freed-Wu commented 1 month ago

Fix #1 Refer https://github.com/mg979/vim-visual-multi/pull/262

black-desk commented 1 month ago

I don't think it is right time for this plugin to be released to non-developer user.

It has so many bugs that I meet all the day. I just do not have time to fix them.

I take a look on rocks.nvim and I think you can just use https://github.com/nvim-neorocks/rocks-git.nvim to install this plugin.

Freed-Wu commented 1 month ago

Or can we publish a scm version? It should give a chance to those users want to adventure.

rocks-git doesn't support declare a dependence, user still declare by themselves.

black-desk commented 1 month ago

Or can we publish a scm version? It should give a chance to those users want to adventure.

I am not familiar with luarocks, may be you mean something like the *-git package in AUR?

black-desk commented 1 month ago

@Freed-Wu And check your email inbox. I send some message to you before.

Freed-Wu commented 1 month ago

Here is scm: https://github.com/black-desk/fcitx5-ui.nvim/pull/8/files#diff-7829468e86c1cc5d5133195b5cb48e1ff6c75e3e9203777f6b2e379d9e4882b3R21

Just like *-git pakcages in AUR. You are right.

black-desk commented 1 month ago

rocks-git doesn't support declare a dependence, user still declare by themselves.

Are you sure about this?

https://github.com/search?q=repo%3Anvim-neorocks%2Frocks-git.nvim%20rockspec&type=code

It seems that we could place a rockspec.lua file into this repository and dependencies will be installed.

update:

I think you are right.

Freed-Wu commented 1 month ago

If use rocks-git, it looks like:

[rocks]
dbus_proxy = "scm"

[plugins."fcitx5-ui.nvim"]
git = "black-desk/fcitx5-ui.nvim"

If we support luarocks directly, it is:

[plugins]
fcitx5-ui.nvim = "scm"

The latter should be better.

black-desk commented 1 month ago

And this commit should not be 'feat:' but 'ci:'.

Check https://www.conventionalcommits.org/en/v1.0.0/

Freed-Wu commented 1 month ago

Fixed.