search

black-mirror-1 / singlestat-math

Panel based on the default single stat panel with added feature to do math across metrics from multiple queries.
MIT License
14 stars 14 forks source link

Allow math to be used for thresholds #16

Closed sillyfrog closed 5 years ago

sillyfrog commented 6 years ago

This supports sorting the thresholds based on the current values calculated for the thresholds if a math based value is used.

sillyfrog commented 6 years ago

This one is further to the other PR to handle sorting correctly based on the current value. GitHub was having some issues when I first tried to merge the PR, however it appears to be working now. Let me know what you think and if it's something you're up for merging. Cheers!

sillyfrog commented 6 years ago

@jfoxe - this PR now includes support for Math in min and max. You can pull from my repo until this is merged. :)

jfoxe commented 6 years ago

@sillyfrog Thanks! works like a charm!

mserna commented 5 years ago

@sillyfrog Can you merge into my developing branch for singlestat-math, so I can test to ensure that everything works correctly. If everything looks good then I'll ask blackmirror to merge into master with your changes as well. :)

sillyfrog commented 5 years ago

@sillyfrog Can you merge into my developing branch for singlestat-math, so I can test to ensure that everything works correctly. If everything looks good then I'll ask blackmirror to merge into master with your changes as well. :)

I'll get to it as soon as I can, it maybe a couple of day, but I'm on it. Cheers!

sillyfrog commented 5 years ago

Sorry all, totally dropped the ball on this. I have now created another PR #30 that should merge cleanly. @mserna Since I took so long it looks like your dev branch has gone, so going back to merging to master - let me know if you want me to send it elsewhere. Thanks!