Closed sillyfrog closed 5 years ago
This one is further to the other PR to handle sorting correctly based on the current value. GitHub was having some issues when I first tried to merge the PR, however it appears to be working now. Let me know what you think and if it's something you're up for merging. Cheers!
@jfoxe - this PR now includes support for Math in min and max. You can pull from my repo until this is merged. :)
@sillyfrog Thanks! works like a charm!
@sillyfrog Can you merge into my developing branch for singlestat-math, so I can test to ensure that everything works correctly. If everything looks good then I'll ask blackmirror to merge into master with your changes as well. :)
@sillyfrog Can you merge into my developing branch for singlestat-math, so I can test to ensure that everything works correctly. If everything looks good then I'll ask blackmirror to merge into master with your changes as well. :)
I'll get to it as soon as I can, it maybe a couple of day, but I'm on it. Cheers!
Sorry all, totally dropped the ball on this. I have now created another PR #30 that should merge cleanly. @mserna Since I took so long it looks like your dev branch has gone, so going back to merging to master - let me know if you want me to send it elsewhere. Thanks!
This supports sorting the thresholds based on the current values calculated for the thresholds if a math based value is used.