black-studio / black-studio-tinymce-widget

Black Studio TinyMCE Widget plugin for WordPress
https://wordpress.org/plugins/black-studio-tinymce-widget/
GNU General Public License v3.0
22 stars 13 forks source link

Moving forward #21

Closed cfoellmann closed 9 years ago

cfoellmann commented 9 years ago

MIxed stuff:

  1. Merge refactor -> develop . I think it is time
  2. Versioning: I think following www.semver.org it would be right to release the refactored version as 1.5 MINOR version when you add functionality in a backwards-compatible manner
  3. Is this line https://github.com/black-studio/black-studio-tinymce-widget/blob/refactor/includes/deprecated.php#L9 needed? Isn't https://github.com/black-studio/black-studio-tinymce-widget/blob/refactor/includes/deprecated.php#L10-L14 enough on its own?
marcochiesi commented 9 years ago
  1. I still want to do some refactoring work on js code before merge refactor to develop
  2. I understand your point, but in this case I would prefer to use a MAJOR version update, since everything changed compared to previous 1.x branch. In particular API has totally changed, and even if things are theoretically backward compatible, this is made by using deprecated functions, that sooner or later may be removed from the codebase. By the way, Wordpress itself has its own version numbering, as it considers s "major version" the first two numbers.
  3. I think you're right. By the way, in the current version the hook function is no more needed as the version is defined statically. Will change that.
cfoellmann commented 9 years ago

about 1: since you do not work on anything beside refactor that needs to be merged into develop it is just an inconvenience to keep refactor. You changed the default branch to develop while actually the default branch is refactor now. Default branch makes it easier to send PRs which it does not do in the current state. Refactoring is an "edge case" but js optimization will not bring any big breaking file/folder changes, right?

marcochiesi commented 9 years ago
  1. JS refactoring is finished and refactor branch has been merged to develop in #23
  2. I updated that code, removing the unneeded hook