search

black-studio / black-studio-tinymce-widget

Black Studio TinyMCE Widget plugin for WordPress
https://wordpress.org/plugins/black-studio-tinymce-widget/
GNU General Public License v3.0
22 stars 13 forks source link

Issue with "Better Font Awesome" plugin #30

Closed FrDH closed 9 years ago

FrDH commented 9 years ago

There seems to be an issue with the latest version and the "Better Font Awesome" plugin. Whenever I activate the "Black Studio TinyMCE Widget" plugin, the dropdown menu with icons that should be added by the "Better Font Awesome" plugin, isn't added at all. This is an issue with the latest version, it worked OK in version 1.4.8

You can reproduce this issue by installing both the "Black Studio TinyMCE Widget" plugin and the "Better Font Awesome" plugin. Now edit a page to see a dropdown menu with icons only if the "Black Studio TinyMCE Widget" is disabled.

cfoellmann commented 9 years ago

I can not reproduce this. See these screenshots: screenshot 2014-10-22 09 48 28 screenshot 2014-10-22 09 48 34 screenshot 2014-10-22 09 48 40

marcochiesi commented 9 years ago

As reported by @cfoellmann everything works fine for me too with Wordpress 4.0, Black Studio TinyMCE Widget 2.1.5 and Better Font Awesome 1.0.4. Please take a look at our troublsehooting FAQ.

FrDH commented 9 years ago

My appologies, the issue seems to be between the "Better Font Awesome" plugin and a combination of the "Black Studio TinyMCE Widget" plugin and the "Page Builder by SiteOrigin" plugin. If I disable either one of the latter, the dropdown menu works, if both are enabled it doesn't.

schermafbeelding 2014-10-22 om 10 51 36

marcochiesi commented 9 years ago

Ok, with Page builder enabled I was able to reproduce the issue. I will look into this and I will let you know.

cfoellmann commented 9 years ago

If it is a bug in page builder they need to fix it. You should send them a patch. Please do not implement another compatibility fix.

FrDH commented 9 years ago

Ok, I'll report the issue to SiteOrigin. Thank you for debugging the issue.

marcochiesi commented 9 years ago

The fix should be made on the Better Font Awesome indeed. In file better-font-awesome/lib/better-font-awesome-library/better-font-awesome-library.php at line 290, change

add_action( 'admin_head', array( $this, 'add_tinymce_components' ) );

to

add_action( 'admin_init', array( $this, 'add_tinymce_components' ) );

I will open a request to Better Font Awesome support forum.

marcochiesi commented 9 years ago

Here's the link to topic on BFA forum.

FrDH commented 9 years ago

Thank you so much.

cfoellmann commented 9 years ago

You could even send a PR :imp: https://github.com/MickeyKay/better-font-awesome-library/blob/master/better-font-awesome-library.php#L290

marcochiesi commented 9 years ago

Made it.