search

blackary / st_pages

An experimental version of Streamlit Multi-Page Apps
MIT License
467 stars 77 forks source link

Empty Space prefix to section name if no icon provided #104

Closed Sairam90 closed 2 months ago

Sairam90 commented 2 months ago

The section names get prefixed by an extra space where icon value is empty - due to this part of the code which is not intended I guess

nav.txt sample_sections.txt

Sairam90 commented 2 months ago

If this is verified I could add a fix - Could you add me as a contributor ?

blackary commented 2 months ago

Great catch! Feel free to make a pull request with a fix!

Sairam90 commented 2 months ago

Am unable to push my local feature branch to the repo Permission to blackary/st_pages.git denied Is it something on my side ?

Also , are any of the tests relevant in this case ? - I am unable to find the fixture "page" when I tried some of them . Could you help with running the tests in case I am missing something there ?

blackary commented 2 months ago

You'll need to create a fork of the repo and create a PR from that fork.

You should be able to run the whole suite of tests by just running tox, but you can also just let them run automatically on github when you create the PR

blackary commented 2 months ago

Closed by #105