search

blackary / st_pages

An experimental version of Streamlit Multi-Page Apps
MIT License
467 stars 77 forks source link

fix encoding #62

Closed wgong closed 1 year ago

wgong commented 1 year ago

have to add encoding="utf-8") when loading emoji.json file

wgong commented 1 year ago

have to add encoding="utf-8") when loading emoji.json file while running your pkg on windows

wgong commented 1 year ago

I comment it out while testing my change and forgot to put it back.

On Tue, Sep 5, 2023 at 10:36 AM Zachary Blackwood @.***> wrote:

@.**** commented on this pull request.

Is there a reason you removed cache_resource? Does that cause issues for you?

— Reply to this email directly, view it on GitHub https://github.com/blackary/st_pages/pull/62#pullrequestreview-1611217975, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACQRSFNVTNQ6L3AC7RIJWDXY42IXANCNFSM6AAAAAA4JQAGAY . You are receiving this because you authored the thread.Message ID: @.***>

--

Thanks, Wen

blackary commented 1 year ago

Change added in #46