blackat / ui-navbar

AngularJS responsive navigation bar with recursive menu and submenu construction defined in json object
MIT License
42 stars 25 forks source link

Can this tool install with bower? #2

Closed vincent-ng closed 8 years ago

vincent-ng commented 8 years ago

It really a cool navbar directive. I think it's preferable to install with bower

blackat commented 8 years ago

Hi, I am glad you like it, I am agree that by Bower it should be better, I will have a look at the process to make available via bower.

blackat commented 8 years ago

@vincentngthu ui-navbar is available via Bower

bower info ui-navbar

thanks for the suggestion :wink:

vincent-ng commented 8 years ago

Thank your for add it to bower.

Two more suggest:

"dependencies": {
    "ui-navbar": "*"
}

It would be nice if you add a "git tag 0.2.4" to the commit. So that the dependencies would become.

"dependencies": {
    "ui-navbar": "~0.2.4"
}

Better for versioning.

"main": "dist/ui-navbar.js"

But the release code is located at "release/js/ui-navbar.js". It is better to have a correct main entry so that some other automatic tools can parse your bower.json.

Thx

blackat commented 8 years ago

Sorry man you are right, I have fixed it.