Closed blackbaud-johnly closed 4 years ago
Merging #47 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #47 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 261 261
Branches 30 30
=========================================
Hits 261 261
Impacted Files | Coverage Δ | |
---|---|---|
...modules/phone-field/phone-field-adapter.service.ts | 100.00% <ø> (ø) |
|
...modules/phone-field/phone-field-input.directive.ts | 100.00% <ø> (ø) |
|
...ublic/modules/phone-field/phone-field.component.ts | 100.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4898d4a...ad42c38. Read the comment docs.
Setting up phase 1.5 docs for phone field. To officially publish phase 2 docs, we still need the behavioral demo and code samples, so I created https://github.com/blackbaud/skyux-phone-field/issues/48 for that work.
Also, in addition to needing someone to review this PR for me, I have a handful of open questions that I need feedback to address:
docs-tools
because we ran into something similar in the Options table for the phase 2 alert component docs. I need someone to check my HTML and confirm whether the is a problem with my HTML or withdocs-tools
. And if it's adocs-tools
issue, does the fact that we are now running into this on multiple topics elevate the priority?SkyPhoneFieldComponent
that does not look like it should be in the docs. I assume this should be a regular comment and should not surface in the docs, but I'm not 100 percent sure, so I need someone to check this and confirm for me.SkyPhoneFieldInputDirective
is pretty long, but I don't see a way around it. I need someone to check behind me to see if we should cut any of this info or put it anywhere else.docs-tools
exposes a bunch of properties forSkyPhoneFieldAdapterService
that were not previously documented. I need someone to check these properties for me and determine whether they should be included in the docs. And if so, I need someone to coordinate with me on what descriptions we need for these methods and parameters.