blackbaud / skyux-phone-field

0 stars 2 forks source link

[HOLD] Phone field phase 2 docs #47

Closed blackbaud-johnly closed 4 years ago

blackbaud-johnly commented 4 years ago

Setting up phase 1.5 docs for phone field. To officially publish phase 2 docs, we still need the behavioral demo and code samples, so I created https://github.com/blackbaud/skyux-phone-field/issues/48 for that work.

Also, in addition to needing someone to review this PR for me, I have a handful of open questions that I need feedback to address:

Blackbaud-TrevorBurch commented 4 years ago
  1. I think this is this issue. https://github.com/blackbaud/skyux-docs-tools/issues/33 @Blackbaud-SteveBrush can you confirm?
  2. I have modified that comment to be a standard comment.
  3. It seems like we could possibly streamline this. Happy to chat. It seems like some of the high level info on the component has moved to the directive and out of the overview. I wonder if some could move back?
  4. The adapter should not have been showing up at all. I marked that as internal.
codecov[bot] commented 4 years ago

Codecov Report

Merging #47 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          261       261           
  Branches        30        30           
=========================================
  Hits           261       261           
Impacted Files Coverage Δ
...modules/phone-field/phone-field-adapter.service.ts 100.00% <ø> (ø)
...modules/phone-field/phone-field-input.directive.ts 100.00% <ø> (ø)
...ublic/modules/phone-field/phone-field.component.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4898d4a...ad42c38. Read the comment docs.

blackbaud-ado commented 4 years ago

Preview build at https://developer.blackbaud.com/skyux-phone-field?_sp.spa=pr-phone-field-phase-2

blackbaud-ado commented 4 years ago

Preview build at https://developer.blackbaud.com/skyux-phone-field?_sp.spa=pr-phone-field-phase-2

blackbaud-ado commented 4 years ago

Preview build at https://developer.blackbaud.com/skyux-phone-field?_sp.spa=pr-phone-field-phase-2