search

blackbaud / skyux-sdk-builder

SKY UX Builder builds the output for SKY UX applications and handles configuration details. It provides for a rapid development process with minimal setup for developers to create single-page applications.
https://developer.blackbaud.com/skyux
MIT License
2 stars 15 forks source link

feat: remove user-scalable option #334

Closed Blackbaud-ColbyWhite closed 3 years ago

Blackbaud-ColbyWhite commented 4 years ago

This prop gets flagged as a best practice violation in the axe browser tools. the h.n.bb.com host does not serve this prop. this ends up causing a false negative for accessibility during local dev on localhost.

this pr removes the false negative and aligns host and local dev.

codecov[bot] commented 4 years ago

Codecov Report

Merging #334 (bdbd49a) into master (42af027) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #334   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         1665      1665           
  Branches       256       256           
=========================================
  Hits          1665      1665
Flag Coverage Δ
builder 100.00% <ø> (ø)
runtime 100.00% <ø> (ø)
srcapp 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 42af027...bdbd49a. Read the comment docs.

Blackbaud-SteveBrush commented 3 years ago

Closing in favor of: https://github.com/blackbaud/skyux-sdk-builder/pull/336