Allow consumers to customize Typescript's and Angular's code-health compiler options

[ThomasOrtiz]

Changes

• Added TS and Angular compiler code-health options to the cherry picked list.
• Updated the library to use Strict Mode and fixed strict mode errors.
  • This was done to ensure that generated SPA code was strict mode compliant.
• Fixed how cherrypicked options we're applied; before the logic had a "truthy" check instead of a "not undefined" check.
  • This prevented people from setting "falsy" values on cherrypicked flags which could be useful if they wanted to turn on strict mode but then turn off specific strict mode flags.

---

Background

• I recently discovered that the tsconfig compiler options are cherrypicked. I agree that it makes sense for core configuration to standardize builds but the implementation limits the use of code-health options.
• SPAs/Libs CAN use strict mode and other code-health options locally but at build time these non-cherrypicked flags are scrubbed away.

Typescript

Why

• See #240

Options

Typescript Compiler Options (click to expand)

[Typescript Compiler Options](https://www.typescriptlang.org/docs/handbook/compiler-options.html) ```TS // These two options are already allowed 'esModuleInterop', 'allowSyntheticDefaultImports', // Typescript Strict Mode enables the following flags 'strict', 'noImplicitAny', 'noImplicitThis', 'alwaysStrict', 'strictBindCallApply', 'strictNullChecks', 'strictFunctionTypes', 'strictPropertyInitialization', // Other recommended TS options 'forceConsistentCasingInFileNames', 'noImplicitReturns', 'noFallthroughCasesInSwitch', 'noUnusedLocals', 'noUnusedParameters' ```

Angular

SkyUX 4 introduced enableIvy, fullTemplateTypeCheck and strictInjectionParameters which are enabled by default.

Why

• Angular's strict mode can work in conjunction with Typescript's strict mode.
• With Sky enabling fullTemplateTypeCheck it allowed teams to use Angular's Full Template Type Checking
• If we allow strictTemplates teams can utilize Angular's Strict Template Type Checking
• Similar reasons to #240.

Options

Angular Compiler Options (click to expand)

```TS 'fullTemplateTypeCheck', // Angular Strict Flags 'strictTemplates', 'strictInputTypes', 'strictInputAccessModifiers', 'strictNullInputTypes', 'strictAttributeTypes', 'strictSafeNavigationTypes', 'strictDomLocalRefTypes', 'strictOutputEventTypes', 'strictDomEventTypes', 'strictContextGenerics', 'strictLiteralTypes', ```

Resources

• Angular CLI Strict Mode
• Angular Compiler Options
• Angular Template Type Checking Modes
• Angular Strict Flag Table

[codecov[bot]]

Codecov Report

Merging #343 (f89ea70) into master (e123570) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #343   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        56    +1     
  Lines         1665      1698   +33     
  Branches       256       268   +12     
=========================================
+ Hits          1665      1698   +33     

Flag	Coverage Δ
builder	100.00% <100.00%> (ø)
runtime	100.00% <ø> (ø)
srcapp	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
lib/sky-pages-route-generator.js	100.00% <ø> (ø)
cli/build-public-library.js	100.00% <100.00%> (ø)
cli/utils/customizable-tsconfig-options.js	100.00% <100.00%> (ø)
cli/utils/run-build.js	100.00% <100.00%> (ø)
src/app/app.component.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e123570...f89ea70. Read the comment docs.