search

blackbaud / skyux1

DEPRECATED This site contains the codebase for the AngularJS (1.x) implementation of the SKY UX framework. We no longer support this version of SKY UX, and we recommend that you use the latest version instead. https://developer.blackbaud.com/skyux/
MIT License
51 stars 68 forks source link

Phone Field Validation Fails For Newer Brazil Numbers #1104

Closed Blackbaud-ScottKavanagh closed 5 years ago

Blackbaud-ScottKavanagh commented 5 years ago

I am working on contribution to address this issue.

Expected behavior

Phone field control phone number validation should pass for Brazilian phone number +5548998386090. https://blackbaud.visualstudio.com/Products/_workitems/edit/1082406

Phone field control phone number validation should pass for new 463 area code in US. https://blackbaud.visualstudio.com/Products/_workitems/edit/1094439

Actual behavior

Phone number is detected as invalid

Steps to reproduce & Plunker

Phone field Plunker enter phone number +5548998386090 https://skyux.developer.blackbaud.com/components/phonefield/

Fix

Dependent library https://intl-tel-input.com/ needs to be updated to the latest version

Blackbaud-ScottKavanagh commented 5 years ago

@Blackbaud-SteveBrush @Blackbaud-TrevorBurch We have 2 client reported issues around this now and some of them are reaching or exceeding our OLAs. Is there anything remaining I need to do here to get this change reviewed and merged?

Blackbaud-ScottKavanagh commented 5 years ago

@Blackbaud-SteveBrush first, thank your for the help getting this fix merged into the SkyUX code. Any idea on when a patch will be available and when we can close this bug down? Nicole Robinson from our PMO side is asking for updates.