search

blackbaud / skyux1

DEPRECATED This site contains the codebase for the AngularJS (1.x) implementation of the SKY UX framework. We no longer support this version of SKY UX, and we recommend that you use the latest version instead. https://developer.blackbaud.com/skyux/
MIT License
51 stars 68 forks source link

Support double-click to highlight keyinfo value/label individually #1129

Open ShaydeNofziger opened 4 years ago

ShaydeNofziger commented 4 years ago

div tags without a separating character (newline or space, for example) causes a "double-click" to highlight the first word of the second div. Add a space after the bb-key-info-value div to prevent the first word in the bb-key-info-label div from being highlighted on double-click. Likewise, this prevents the last word of the bb-key-info-value div from being highlighted upon double-click of the bb-key-info-label div.

This is re-produceable in latest version of Edge and Chrome on Windows 10. I have tested the fix in both browsers.

Alternative to a space after the bb-key-info-value would be a single newline between the two divs. That may be more readable to future maintainers.

I'll leave it up to maintainers as to which is preferred (space vs newline).

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

blackbaud-sky-savage commented 4 years ago

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 5a23ce8fefb0121d14fca3b392be62ec9aee497b Build details: https://travis-ci.org/blackbaud-sky-savage/skyux/builds/682093711

(Please note that this is a fully automated comment.)

ShaydeNofziger commented 4 years ago

Screenshots of how this looks after double-clicking the key-value:

Before fix: image

After fix: image