search

blackbaud / skyux2

SKY UX 2 is the new version of Blackbaud’s user experience framework that implements Blackbaud design patterns. It extends the framework to abstract many complexities of modern web development and takes advantage of Angular 2 to increase the tooling, testing, and performance available.
https://developer.blackbaud.com/skyux
MIT License
32 stars 65 forks source link

Modals sometimes receive a visible 'focused' border around content #2146

Closed jeffbdye closed 5 years ago

jeffbdye commented 6 years ago

Expected behavior

No border appears

Actual behavior

On latest chrome, a small blue border appears surrounding the modal-content element when the modal content does not contain an input element. Doesn't appear to happen on latest firefox.

Steps to reproduce

Create a modal without an input field in the sky-modal-content, open the modal in chrome, see the blue-ish focus border around the modal-content.

Plunker

https://next.plnkr.co/edit/uv44WosD1IYeLfp6zYl0?p=preview&utm_source=legacy&utm_medium=worker&utm_campaign=next&preview

Severity

Minimal

Impact

Only appears to affect modals without an input element - the confirm component shows a similar border around the buttons on the bottom (indicating they are given focus initially)

blackbaud-conorwright commented 6 years ago

We have to keep the focus visually indicated here, but are going to try and improve the appearance of the focus. Hopefully to make it more subtle