search

blackbaud / skyux2

SKY UX 2 is the new version of Blackbaud’s user experience framework that implements Blackbaud design patterns. It extends the framework to abstract many complexities of modern web development and takes advantage of Angular 2 to increase the tooling, testing, and performance available.
https://developer.blackbaud.com/skyux
MIT License
32 stars 65 forks source link

Fix confusing documentation around autocomplete component's `data` input #2228

Closed Blackbaud-SteveBrush closed 5 years ago

Blackbaud-SteveBrush commented 5 years ago

The data input currently says that the information can be pulled "from a database", but this isn't accurate since the input represents a static array. The last sentence should be closer to: "You can specify a static array of objects".

https://developer.blackbaud.com/skyux/components/autocomplete#properties

Blackbaud-PeteLukich commented 5 years ago

Could you also put some wording in the data property description that says "When binding to an array of dynamic data (that will change due to server calls, etc), please use the search property instead"

... if you think that is accurate ^

blackbaud-johnly commented 5 years ago

Addressed in https://github.com/blackbaud/skyux2-docs/pull/187.