blackbaud / skyux2

SKY UX 2 is the new version of Blackbaud’s user experience framework that implements Blackbaud design patterns. It extends the framework to abstract many complexities of modern web development and takes advantage of Angular 2 to increase the tooling, testing, and performance available.

https://developer.blackbaud.com/skyux

MIT License

32 stars 65 forks source link

Improved flyout demo & show iterator #2239

Closed Blackbaud-AlexKingman closed 5 years ago

Blackbaud-AlexKingman commented 5 years ago

Added several examples of how to use flyout. Split complicated grid into its own demo to show how to use flyout with provider and iterator.

Addresses #2241

codecov-io commented 5 years ago

Codecov Report

Merging #2239 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2239   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files          22       22           
  Lines         121      121           
  Branches       12       12           
=======================================
  Hits          119      119           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 619e6af...6d744e1. Read the comment docs.

Blackbaud-AlexKingman commented 5 years ago

This is ready for another pass. All "rough" stuff has been refined and code is intended for final review.

blackbaud-conorwright commented 5 years ago

For the buttons with simple flyouts, could they be justified in some way? It's kind of weird to look through at the moment. The button labels could stand to be shorter too, but I'm not sure of good alternatives on that so maybe not. 😜

Otherwise, this demo looks fine to me for demonstrating flyouts and the nav-button functionality

Blackbaud-AlexKingman commented 5 years ago

@blackbaud-conorwright ready for you again. I think I saw to every comment above, plus I organized the buttons to be a bit more tidy in the interest of legibility.

Blackbaud-AlexKingman commented 5 years ago

@Blackbaud-ToddRoberts @blackbaud-johnly Docs and UX changes have been made. Ready for final review.