blackbaud / skyux2

SKY UX 2 is the new version of Blackbaud’s user experience framework that implements Blackbaud design patterns. It extends the framework to abstract many complexities of modern web development and takes advantage of Angular 2 to increase the tooling, testing, and performance available.

https://developer.blackbaud.com/skyux

MIT License

32 stars 65 forks source link

Updated demos for checkbox and radio components to show the label property in use #2261

Closed Blackbaud-TrevorBurch closed 5 years ago

Blackbaud-TrevorBurch commented 5 years ago

@Blackbaud-MattGregg @blackbaud-johnly I have updated both the checkbox and radio component demos to show the use of the label property with icon versions of these components.

Blackbaud-TrevorBurch commented 5 years ago

Addresses feedback from #2234 and #2235

codecov-io commented 5 years ago

Codecov Report

Merging #2261 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2261   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files          22       22           
  Lines         121      121           
  Branches       12       12           
=======================================
  Hits          119      119           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d00006a...b9c2665. Read the comment docs.

Blackbaud-MattGregg commented 5 years ago

@Blackbaud-TrevorBurch The checkbox demo looks good. When I view the radio button demo it still has the aria-label property missing on the icon radio button examples.

radio_aria_missing

Blackbaud-TrevorBurch commented 5 years ago

Hey @Blackbaud-MattGregg can you try pulling down the latest version of the branch again? I'm seeing the property fine but I had fixed an issue earlier in the day that you reviewed and I'm wondering if you possibly just didn't have the latest version when you checked it out. Thanks! :)

Blackbaud-MattGregg commented 5 years ago

Grabbing that branch again did it. Looks good to me. Thanks.