search

blackbaud / skyux2

SKY UX 2 is the new version of Blackbaud’s user experience framework that implements Blackbaud design patterns. It extends the framework to abstract many complexities of modern web development and takes advantage of Angular 2 to increase the tooling, testing, and performance available.
https://developer.blackbaud.com/skyux
MIT License
32 stars 65 forks source link

Conditional date pickers in modals break scroll bar. #2349

Closed clo-dev closed 5 years ago

clo-dev commented 5 years ago

Expected behavior

When I use a conditional Datepicker component (*ngIf) within a modal whose content needs vertical scrollbar, I should see the vertical scroll bar.

Actual behavior

When I use a conditional Datepicker component (*ngIf) within a modal whose content needs vertical scrollbar, I do not see a vertical scroll bar.

Steps to reproduce

1) Open a modal with enough content to force a vertical scroll bar. 2) Add a conditional Datepicker component.

Plunker

Plunkr templates seem to be broken so I could not provide a working demo.

Notes

The issue started after v2.35.0 of SKYUX.

Blackbaud-TrevorBurch commented 5 years ago

@kidchunks I'm looking into this issue and was able to replicate.

However, in the meantime I did confirm that if the ngIf starts off as false everything works. So you could use this as a work around if needed.