pdf from buffer - Githubissues

blackbeam / poppler-simple

A simple javascript interface to poppler library

Apache License 2.0

37 stars 14 forks source link

Closed magicode closed 8 years ago

blackbeam commented 8 years ago

Hi! Thanks for contribution.

It looks like tests fails on your changes. Could you please look into errors? To run tests locally execute this commands in repo's root:

npm install # to rebuild
npm test # to run tests

magicode commented 8 years ago

i fixed it.

blackbeam commented 8 years ago

And one more issue. Please reindent with 4 spaces per indentation level.

blackbeam commented 8 years ago

Thanks. Will publish asap.

blackbeam commented 8 years ago

Can't publish. Looks like MemStream is unstable on linux. Need more spare time to investigate this..

blackbeam commented 8 years ago

Published as v0.2.3

magicode commented 8 years ago

Thank you very much.