When running npm install poppler-simple, if the node-gyp compilation fails the npm install still succeeds. This is undesirable because it is hard to tell what went wrong (especially if it fails as part of a lengthy npm install). The problem appears to be these few lines --
https://github.com/blackbeam/poppler-simple/blob/master/package.json#L14
Where exit 0 should probably be exit 1.
blackbeam
commented
8 years ago
When running
npm install poppler-simple, if the node-gyp compilation fails the npm install still succeeds. This is undesirable because it is hard to tell what went wrong (especially if it fails as part of a lengthynpm install). The problem appears to be these few lines -- https://github.com/blackbeam/poppler-simple/blob/master/package.json#L14 Whereexit 0should probably beexit 1.