Optsbuilder from hashmap

blackbeam / rust-mysql-simple

Mysql client library implemented in rust.

Apache License 2.0

659 stars 144 forks source link

Closed hpca01 closed 3 years ago

hpca01 commented 3 years ago

Hi @blackbeam

Added ability to set up from HashMap<String,String>, also added a test case in the opts.rs file to test the change.

Let me know if I missed something, my Rust is a bit rusty :laughing:

Thanks for allowing me to contribute!

hpca01 commented 3 years ago

Hi @blackbeam

I added the following:

The other remaining URL params
Throw UnknownParameter exception when a key passed in via HashMap is not recognized
Adjusted the documentation for the function to include the additional URL params
Adjusted the test case to test for the additional URL params.

Thanks! Let me know if there's any adjustments needed.

blackbeam commented 3 years ago

@hpca01, thanks!