Closed gliderkite closed 3 years ago
Hi, thanks for PR! I'm on a trip at the moment, so I'll look into it a bit later.
Hi, thanks. Please note that I also tried to return Some(Err(error))
instead (I had to create a dummy error since the current one cannot be cloned). But it also hangs in that case.
This is superseded by e5db79d. Closing. Thanks!
Where I work we use this library quite a lot (thanks for the work!), but we stumbled against an issue that I can reproduce also on the latest version of this library (currently
21.0.0
).Basically when executing an invalid query the code hangs and it's fortunately reproducible 100% of the time. The code that triggers the issue looks like the following:
After a bit of debugging I noticed that it hangs on
QueyResult::drop
, in particular at the 3rd call ofQueryResult::next_set
.This MR is a first attempt to solve the issue, we are currently using this patch since it fixes the issue, however I do not have enough context to understand the consequences of this change, nor currently the time to implement some tests. Please feel free to merge if you think this is indeed a fix, to take it over, or to guide me over the following steps.