blackbeam / rust-mysql-simple

Mysql client library implemented in rust.
Apache License 2.0
652 stars 145 forks source link

Can't use p12 cert without password, get MAC verification failed during PKCS12 import #369

Closed invm closed 5 months ago

invm commented 6 months ago

Hi,

I'm having an issue using a p12 without a password, while a cert that has been exported with a password works as expected, trying to create an identity with a p12 without a password throws an incorrect password error:

TlsError { MAC verification failed during PKCS12 import (wrong password?) }

I tried providing an empty password with the same results, maybe I'm missing something, would like some assistance.

Export a p12 without a password and try to run this code :

use std::path::PathBuf;

use anyhow::Result;
use mysql::{prelude::Queryable, ClientIdentity, Opts, OptsBuilder, Pool, Row, SslOpts};
use tracing::debug;

#[tokio::main]
async fn main() -> Result<()> {
    tracing_subscriber::fmt::init();

    let identity = ClientIdentity::new(PathBuf::from(
        "/Users/dev/certs/client.p12",
    ))
    let ssl_opts = SslOpts::default()
        .with_client_identity(Some(identity))
        .with_danger_accept_invalid_certs(true);

    let builder = OptsBuilder::new()
        .ip_or_hostname(Some("localhost"))
        .tcp_port(3306)
        .user(Some("root"))
        .pass(Some("example"))
        .db_name(Some("world"))
        .tcp_connect_timeout(Some(std::time::Duration::from_secs(15)))
        .ssl_opts(ssl_opts);

    let opts = Opts::from(builder);
    let pool = Pool::new(opts)?;
    let mut conn = pool.get_conn()?;
    let results: Vec<Row> = conn.query("SELECT * FROM city limit 1")?;
    debug!("results: {:?}", results);
    Ok(())
}

While changing the identity to provide a password works as expected

    let identity = ClientIdentity::new(PathBuf::from(
        "/Users/dev/certs/client-1234.p12",
    )).with_password("1234");
invm commented 5 months ago

Forgot to mention I had this issue on Macos, this issue has nothing to do with this crate, looks like a Macos security framework issue.

As stated here

...unencrypted PKCS#12 data is not supported.

This could probably be solved by specifying the format like described here

I'm closing the issue.