blackbeltlabs / TextAnnotation

Swift text annotation component for macOS.
MIT License
5 stars 2 forks source link

Text style improvements #19

Open mirkokiefer opened 4 years ago

mirkokiefer commented 4 years ago

The goal of these improvements are for the user to more easily see when they are editing text vs. moving the textbox or changing the font color.

Users should also be able to see the text cursor more easily.

Changes to be made:

All designs: https://www.sketch.com/s/cbee8789-1f25-4bee-b531-61ff06599e7f/p/text-annotation

ulian-onua commented 4 years ago

@mirkokiefer this issue seems to be the same as described on Basecamp in this task https://3.basecamp.com/4508093/buckets/16969896/todos/2898148143

I continue working on it.

mirkokiefer commented 4 years ago

@ulian-onua how is the current outline shadow realized? Saw your comment in Basecamp. The double drawing seems a bit nasty - I would worry about how this looks while typing. Is there no way to just adjust the font properties?

ulian-onua commented 4 years ago

@mirkokiefer @memstel

ulian-onua commented 4 years ago

@ulian-onua how is the current outline shadow realized? Saw your comment in Basecamp. The double drawing seems a bit nasty - I would worry about how this looks while typing. Is there no way to just adjust the font properties?

@mirkokiefer the current outline settings (not shadow) use the property called: NSAttributedString.Key.strokeWidth. It is current value is -1.5.

We can play with it. For example. if changed to -3.5 then will look like this: image

If changed to -5.0 then looks like this: image

If changed to -8.0 then looks like this: image

We can see that the outline isn't solid in this case and this setting just adds white border around each letter and letters look like decreased