blackberry / Alice

AliceJS - (A Lightweight Independent CSS Engine) is a micro JavaScript library. For a demo, click the link below.
http://blackberry.github.com/Alice/
Apache License 2.0
425 stars 59 forks source link

IE 10 support #33

Open erothvt opened 12 years ago

erothvt commented 12 years ago

It turns out, at least in the release preview, IE 10 style element is case sensitive. So in the javascript where it is checking for "MSAnimation" this will always fail. But it will find "msAnimation". So if you update this code in alice.core from: // Internet Explorer 10+ else if ("MSAnimation" in el.style) { this.prefix = "-ms-"; this.prefixJS = "MS"; }

to: // Internet Explorer 10+ else if ("msAnimation" in el.style) { this.prefix = "-ms-"; this.prefixJS = "ms"; }

Alice will then work in IE10 release preview.

However it turns out you do not need the ms prefix for css3 animations to work in IE10 but again it is case sensitive, so where all the style elements are being set, when in IE the first letter must be lower case for example when setting the "AnimationName" it must be "animationName".

Doing this will of coarse break everything when you do need a prefix, so for now it is probably best to keep the ms prefix.

mlantz commented 12 years ago

Thanks a bunch for the info. I'll tend to that asap!

ldhasson commented 12 years ago

Very interesting... I'd assume we tested this, but I guess not. Thanks. Will put this in.

Thank You

- Twitter: @ldhasson -

"Strange women lyin' in ponds distributin' swords is no basis for a system of government" - Dennis

-----Original Message----- From: erothvt [mailto:reply@reply.github.com] Sent: Wednesday, July 25, 2012 5:05 PM To: Laurent Hasson Subject: [Alice] IE 10 support (#33)

It turns out, at least in the release preview, IE 10 style element is case sensitive. So in the javascript where it is checking for "MSAnimation" this will always fail. But it will find "msAnimation". So if you update this code in alice.core from: // Internet Explorer 10+ else if ("MSAnimation" in el.style) { this.prefix = "-ms-"; this.prefixJS = "MS"; }

to: // Internet Explorer 10+ else if ("msAnimation" in el.style) { this.prefix = "-ms-"; this.prefixJS = "ms"; }

Alice will then work in IE10 release preview.

However it turns out you do not need the ms prefix for css3 animations to work in IE10 but again it is case sensitive, so where all the style elements are being set, when in IE the first letter must be lower case for example when setting the "AnimationName" it must be "animationName".

Doing this will of coarse break everything when you do need a prefix, so for now it is probably best to keep the ms prefix.


Reply to this email directly or view it on GitHub: https://github.com/blackberry/Alice/issues/33


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.