search

blackberry / BB10-WebWorks-Community-Samples

WebWorks Samples for the BlackBerry 10 Platform contributed by the Community
Apache License 2.0
44 stars 91 forks source link

Submodule suggestion for BoxQuest #19

Closed linshun closed 11 years ago

linshun commented 11 years ago

"To successfully compile this application, you will need to copy the the cocos2d and CocosDenshion folders from the Cocos2d-HTML5 Github repository into the cocos subfolder of this project. The repository is available here: https://github.com/cocos2d/cocos2d-html5"

I suggest you to use a submodule instead of copying. The developers always don't know which version of Cocos2d-html5 will be work well with this sample.

timwindsor commented 11 years ago

@oros this is a pretty good suggestion. Interested in looking at how git submodules work? I've seen it used with the Enyo bootplate project here: https://github.com/enyojs/bootplate

oros commented 11 years ago

I haven't used submodules but I like this idea (assuming I'm understanding correctly.) @timwindsor I'll drop by for a discussion soon.

cdelcol commented 11 years ago

WebWorks uses them. Some things work really well, other uses make life very complicated. I'd say for a sample that just needs a "supported" version of a library it is a perfect use for them.

oros commented 11 years ago

I have my attempt at submodules staged here: https://github.com/oros/BB10-WebWorks-Community-Samples/tree/master/BoxQuest

Basically I command-lined it: git submodule add https://github.com/cocos2d/cocos2d-html5.git boxquest/cocos/

But I can't tell whether I've done it right. I thought the icon for the 'cocos' folder would look different (as in Tim's sample repo) after I pushed the changes back from my PC to Github, but it looks like a regular folder. @timwindsor I may need you to drop by sometime tomorrow to help sort this out.

linshun commented 11 years ago

I will send you a Pull Request to add the submodule today . :)

oros commented 11 years ago

I may have just gotten it...I'm not sure exactly how though, so give me a few moments to confirm :-)

oros commented 11 years ago

I do believe I've done something wrong. It's showing up now: https://github.com/oros/BB10-WebWorks-Community-Samples/tree/master/BoxQuest

But it's red, and doesn't link anywhere. I'll take that Pull Request if it's still on the table :-)

linshun commented 11 years ago

You forgot to push .gitmodules file which it is hidden file. So it can't work well. :)

oros commented 11 years ago

Well, this will be a learning experience if nothing else...okay, just found this: http://blog.jacius.info/git-submodule-cheat-sheet/

Here goes attempt number three.

oros commented 11 years ago

Could it be that Github simply hasn't caught up? I'm seeing my commits: https://github.com/oros/BB10-WebWorks-Community-Samples/commits/master

Which look right (to me anyways), but the files I thought would be affected aren't. I need to pack up for the night but will get this sorted in the AM.

linshun commented 11 years ago

I fixed the problem. Your path should be "path = BoxQuest/cocos", but no "path = boxquest/cocos".

oros commented 11 years ago

Woohoo! That seems to have done it. Oh, proper capitalization.

oros commented 11 years ago

@linshun Pull request is in, let me know what you think of the new guide/tutorials section (eoros@rim.com) once it's live. And thanks again for the help there, I was pretty lost by attempt number three.

oros commented 11 years ago

@timwindsor I think this one can be closed with the latest merge that was approved.