blackberry / BB10-WebWorks-Framework

The BB10 WebWorks Framework is packaged within an application BAR file to run on a BB10 device (or simulator)
60 stars 34 forks source link

MANIFEST.MF file references "Tablet OS" #306

Open astanley opened 12 years ago

astanley commented 12 years ago

Inspecting the MANIFEST.MF file of a compiled BAR, I see the following reference to "Tablet OS" :

Application-Requires-System: Tablet OS/10.0.4.0

Recommend changing this to "BB10" or "BlackBerry10". We are trying to start reporting of apps in App World, and it would be more helpful to filter on a more complete identifier than just the trailing version number.

HOWEVER - will this change affect the AppId for existing apps in App World (ie. will it result in duplicate installs)?

nukulb commented 12 years ago

We don't generate a Manifest.MF file we simply call the Native Packager which generates it.

astanley commented 12 years ago

Do you feel this is something that should be corrected? I can file a PR ?

nukulb commented 12 years ago

you need to try a native app using the Native Packager and if that is also generating the same problem then file a PR. WebWorks doesn't seem to be adding this but that could just mean that we need to explicitly add BB10

Try a native app and lets take it from there.

mihai2 commented 12 years ago

Native apps have the same entry

nukulb commented 12 years ago

@astanley - you have your answer. I don't mind leaving this open here but can you please post the internal PR number here just for tracking purposes.

nukulb commented 12 years ago

labels edited.