search

blackberry / BB10-WebWorks-Framework

The BB10 WebWorks Framework is packaged within an application BAR file to run on a BB10 device (or simulator)
60 stars 35 forks source link

Using BB10 Webworks will break if app uses any module loader #70

Closed gtanner closed 11 years ago

gtanner commented 12 years ago

If the app includes a module loader before or after including webworks.js the app will not work the way they would expect it too.

Including webworks.js before and webworks will not run Including webworks.js after and all of the app's modules will no longer exist.

Same issue existed in Cordova and solved here: https://github.com/apache/incubator-cordova-js/commit/07b5166da42811d12ca25a16e517406935685ebd

rcruz commented 12 years ago

An app will not be able to use our included version of browser-require inside of webworks.js.

We are currently loading browser-require, then altering the main function. This alteration adds a base url to where the files are being loaded, which helps us load APIs easier. If a webworks app tries to use our bundled version of require, and base url will be applied and it will not work correctly.

gtanner commented 12 years ago

The problem is if they include browser-require in their app and include it in their markup Sent on the TELUS Mobility network with BlackBerry

gtanner commented 12 years ago

Any word on this? Kinda a biggie as require.js / browser-require / etc are being used a lot in the wild.

nukulb commented 12 years ago

agreed its a biggie, it is not being fixed for this Beta1, it is in scope for Beta2