As a WebWorks developer, I can lock the orientation of my application

kwallis commented 12 years ago

Acceptance Criteria

Orientation will be defined as a element in the config.xml, as a child of the element
The packager should currently ignore this feature if it is found as a child of an
element.
- This feature should currently be treated as an application-wide feature
- We should open an issue that this feature does not adhere to our usage of elements, in that it is app wide and not part of the implied "local" scope, and is not applicable inside elements.
Use feature id="blackberry.app.orientation"
value for orientation will be passed in using a child element
name for the param will be "mode"
Possible values for orientation are:
- auto
- landscape
- portrait
- north - This means that the app should be locked in an orientation where the top of the app should be locked to the logical "top" of the device when a user is holding the device in the typical orientation. eg. for a smartphone, the headset speaker is at the top, etc.
If no orientation feature is specified, then the app will behave as if the "auto" value were passed in.
Update status of internal PR https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=158252

nukulb commented 12 years ago

what does "at runtime" mean?

do you want this in the config.xml or an api?

To be config.xml is not runtime, its like build time where as an api is runtime.

kwallis commented 12 years ago

Updated description and title.

nukulb commented 12 years ago

aspect ratio tag seems like the one we should use https://bdsc.webapps.blackberry.com/native/documentation/com.qnx.doc.native_sdk.devguide/com.qnx.doc.native_sdk.devguide/topic/r_barfile_dtd_ref_aspectratio.html

kwallis commented 12 years ago

This is a tag in the bar manifest? Can we ensure this maps to navigator functionality, as in understand you used to be able to do things like this on Screen, but that moving forward it all has to go through Navigator.

----- Original Message ----- From: Nukul Bhasin [mailto:reply@reply.github.com] Sent: Friday, May 04, 2012 06:55 AM To: Ken Wallis Subject: Re: [BB10-Webworks-Packager] As a WebWorks developer, I can lock the orientation of my application so that it runs in portrait or landscape only (#108)

aspect ratio tag seems like the one we should use https://bdsc.webapps.blackberry.com/native/documentation/com.qnx.doc.native_sdk.devguide/com.qnx.doc.native_sdk.devguide/topic/r_barfile_dtd_ref_aspectratio.html

Reply to this email directly or view it on GitHub: https://github.com/blackberry/BB10-Webworks-Packager/issues/108#issuecomment-5508096

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

nukulb commented 12 years ago

this declarative for the blackberry-tablet.xml. Isn't that what you want? I am confused you said it needs to be in the config.xml

kwallis commented 12 years ago

From the webworks developer perspective, yes, I want it in config.xml.

What I want to understand is ultimately how does this translate at the native end to ensure we are built on the right thing.

If we just translate our config to something in tablet.xml, let's just make sure to follow the thread through the native packager and down and make sure we are ultimately leveraging the right component (navigator I think?) to control this.

----- Original Message ----- From: Nukul Bhasin [mailto:reply@reply.github.com] Sent: Friday, May 04, 2012 11:22 AM To: Ken Wallis Subject: Re: [BB10-Webworks-Packager] As a WebWorks developer, I can lock the orientation of my application so that it runs in portrait or landscape only (#108)

this declarative for the blackberry-tablet.xml. Isn't that what you want? I am confused you said it needs to be in the config.xml

Reply to this email directly or view it on GitHub: https://github.com/blackberry/BB10-Webworks-Packager/issues/108#issuecomment-5512854

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

nukulb commented 12 years ago

I have no idea what this means "follow the thread through the native packager and down and make sure we are ultimately leveraging the right component (navigator I think?) to control this"?

If we are using the native packager how are we suppose to know what it uses once it bundles the app and it puts it on the device? I think we have rely on the fact that this flag will ultimately be updated to use the right component on the OS even if it is not using the right component right now

jeffheifetz commented 12 years ago

Is there any possibility of adding support for something like a "north" orientation. This was a feature missing in our previous orientation locks.

In the old blackberry world portrait did not always mean facing up ( I think this was true for bolds and curves). This created an issue for developers targeting keyboard devices as well as torches because torches would need to be locked in portrait while other devices would need to be locked in landscape. Allowing the specification of something like north, which would mean facing up independent of screen dimensions, could be helpful.

kwallis commented 12 years ago

We had added that to the latest Smartphone SDK, so this should make it over to BB10 as well.

Ken Wallis

Product Manager – BlackBerry WebWorks

Research In Motion

(905) 629-4746 x14369

From: Jeffrey Heifetz [reply@reply.github.com] Sent: Tuesday, May 22, 2012 11:52 AM To: Ken Wallis Subject: Re: [BB10-Webworks-Packager] As a WebWorks developer, I can lock the orientation of my application so that it runs in portrait or landscape only (#108)

Is there any possibility of adding support for something like a "north" orientation. This was a feature missing in our previous orientation locks.

In the old blackberry world portrait did not always mean facing up ( I think this was true for bolds and curves). This created an issue for developers targeting keyboard devices as well as torches because torches would need to be locked in portrait while other devices would need to be locked in landscape. Allowing the specification of something like north, which would mean facing up independent of screen dimensions, could be helpful.

Reply to this email directly or view it on GitHub: https://github.com/blackberry/BB10-Webworks-Packager/issues/108#issuecomment-5850731

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

jeffheifetz commented 12 years ago

@kwallis If we added it someone should update our docs - https://bdsc.webapps.blackberry.com/html5/documentation/ww_developing/RIM_orientation_element_1594186_11.html

kwallis commented 12 years ago

cc @caseden @dmateescu Good catch, yes we need to update the docs to indicate that portrait was replaced with NORTH in 2.3.1 for SmartPhone.

Ken Wallis

Product Manager – BlackBerry WebWorks

Research In Motion

(905) 629-4746 x14369

From: Jeffrey Heifetz [reply@reply.github.com] Sent: Tuesday, May 22, 2012 12:46 PM To: Ken Wallis Subject: Re: [BB10-Webworks-Packager] As a WebWorks developer, I can lock the orientation of my application so that it runs in portrait or landscape only (#108)

@kwallis If we added it someone should update our docs - https://bdsc.webapps.blackberry.com/html5/documentation/ww_developing/RIM_orientation_element_1594186_11.html

Reply to this email directly or view it on GitHub: https://github.com/blackberry/BB10-Webworks-Packager/issues/108#issuecomment-5852176

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

jeffheifetz commented 12 years ago

@kwallis Just to clarify, north should be in addition to portrait, shouldn't it?

kwallis commented 12 years ago

For BB10, yes, in addition. My apologies for the confusion, as I believe for WebWorks for Smartphone it replaced portrait based on the code I saw...

Ken Wallis

Product Manager – BlackBerry WebWorks

Research In Motion

(905) 629-4746 x14369

From: Jeffrey Heifetz [reply@reply.github.com] Sent: Tuesday, May 22, 2012 1:39 PM To: Ken Wallis Subject: Re: [BB10-Webworks-Packager] As a WebWorks developer, I can lock the orientation of my application so that it runs in portrait or landscape only (#108)

@kwallis Just to clarify, north should be in addition to portrait, shouldn't it?

Reply to this email directly or view it on GitHub: https://github.com/blackberry/BB10-Webworks-Packager/issues/108#issuecomment-5853553

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

kwallis commented 12 years ago

Updated description based on design conversations.

ghost commented 12 years ago

For the "North" attribute, I'll add the following to the configuration documentation:

north

The north attribute specifies that screen orientation remains in portrait mode, with the top of the application screen aligned to the top of the device (for example, the "top" on BlackBerry smartphones is typically where the speaker is located).

This attribute is available only in BlackBerry WebWorks SDK for Smartphones 2.3 and later.

This attribute is optional.

Acceptable? @jeffheifetz @kwallis

kwallis commented 12 years ago

It is not tied to portrait mode. For example, North on a Bold 9900 would really equate to landscape in relation to the screen dimensions.

Ken Wallis

Product Manager – BlackBerry WebWorks

Research In Motion

(905) 629-4746 x14369

From: Barb Paduch [notifications@github.com] Sent: Tuesday, September 04, 2012 9:57 AM To: blackberry/BB10-Webworks-Packager Cc: Ken Wallis Subject: Re: [BB10-Webworks-Packager] As a WebWorks developer, I can lock the orientation of my application (#108)

For the "North" attribute, I'll add the following to the configuration documentation:

north

The north attribute specifies that screen orientation remains in portrait mode, with the top of the application screen aligned to the top of the device (for example, the "top" on BlackBerry smartphones is typically where the speaker is located).

This attribute is available only in BlackBerry WebWorks SDK for Smartphones 2.3 and later.

This attribute is optional.

Acceptable? @jeffheifetzhttps://github.com/jeffheifetz @kwallishttps://github.com/kwallis

— Reply to this email directly or view it on GitHubhttps://github.com/blackberry/BB10-Webworks-Packager/issues/108#issuecomment-8263622.

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

kwallis commented 12 years ago

I believe we are unblocked on this. @nukulb when can we start work on this?

jamesjhedley commented 12 years ago

FYI, it appears as though "north" is not supported in the native-packager yet. I have added support for north on our side, but until native-packager supports it, the user will get a native-packager exception when packaging.

[INFO] [ERROR] MANIFEST.MF: Invalid value 'north' for attribute 'Entry-Point-Orientation'. [ERROR] Native Packager exception occurred

ghost commented 12 years ago

@kwallis @jkeshavarzi @nukulb

So, for BB10, instead of using the existing config.xml element, this functionality must be used with a feature id and param element?

blackberry / BB10-Webworks-Packager