As a WebWorks developer, I can enable the flash plug-in for my application to render flash content

kwallis commented 12 years ago

Acceptance Criteria

Flash will be defined as a element in the config.xml, as a child of the element
The packager should currently ignore this feature if it is found as a child of an
element.
- This feature should currently be treated as an application-wide feature
- We should open an issue that this feature does not adhere to our usage of elements, in that it is app wide and not part of the implied "local" scope, and is not applicable inside elements.
Use feature id="enable-flash"
If the feature is present, then flash support will be enabled for the application
By default, the flash plug-in will be disabled.

kwallis commented 12 years ago

TODO: Need to define a "content" settings area in config where this will reside. Will Impact the string pattern as well.

nukulb commented 12 years ago

@kwallis - I don't like this setting that much, is there a more general setting we can come up with

nukulb commented 12 years ago

@gtanner - another config.xml addtion that sucks

Enabling flash any recommendations?

gtanner commented 12 years ago

would this not just be a feature:

<feature id="adobe.flash" />

cdelcol commented 12 years ago

It works completely different from other "features". This sets the value for the app, and would have no actual developer api. it is not a bad idea, but would be the first of its kind. These flags have always been handled in the config.xml outside of "features" in the past.

gtanner commented 12 years ago

Yeah, I am not in love with it either, I am just going by the w3c spec of features:

http://www.w3.org/TR/widgets/#the-feature-element-and-its-attributes

specifically:

A feature is a URI identifiable runtime component (e.g. an Application Programming Interface or video decoder).

Where the term video decoder is kind of interesting as it doesn't have any API but is just a codec.

As a goal I would like us to stick close to the w3c guidelines for config.xml.

jeffheifetz commented 12 years ago

In this case I think it makes most sense as a permission as opposed to a feature.

While I agree that it fits with the W3C definition, I feel it meshes better with our usage of permissions.

gtanner commented 12 years ago

The only problem is that isn't standard ;)

I do agree it fits better there than as rim:enableFlash

nukulb commented 12 years ago

Maybe all permissios should be features

Sent from my BlackBerry device on the Rogers Wireless Network

-----Original Message----- From: Gord Tanner notifications@github.com Date: Wed, 8 Aug 2012 09:12:57 To: blackberry/BB10-Webworks-PackagerBB10-Webworks-Packager@noreply.github.com Reply-To: blackberry/BB10-Webworks-Packager reply@reply.github.com Cc: Nukul Bhasinme@nukulb.com Subject: Re: [BB10-Webworks-Packager] As a WebWorks developer, I can enable the flash plug-in for my application to render flash content (#166)

The only problem is that isn't standard ;)

I do agree it fits better there than as rim:enableFlash

Reply to this email directly or view it on GitHub: https://github.com/blackberry/BB10-Webworks-Packager/issues/166#issuecomment-7588572

nukulb commented 12 years ago

I vote we make it a feature but this is on @kwallis to make a call.

Sent from my BlackBerry device on the Rogers Wireless Network

-----Original Message----- From: me@nukulb.com Date: Wed, 8 Aug 2012 16:16:23 To: blackberry/BB10-Webworks-Packagerreply@reply.github.com; blackberry/BB10-Webworks-PackagerBB10-Webworks-Packager@noreply.github.com Reply-To: me@nukulb.com Subject: Re: [BB10-Webworks-Packager] As a WebWorks developer, I can enable the flash plug-in for my application to render flash content (#166)

Maybe all permissios should be features

Sent from my BlackBerry device on the Rogers Wireless Network

-----Original Message----- From: Gord Tanner notifications@github.com Date: Wed, 8 Aug 2012 09:12:57 To: blackberry/BB10-Webworks-PackagerBB10-Webworks-Packager@noreply.github.com Reply-To: blackberry/BB10-Webworks-Packager reply@reply.github.com Cc: Nukul Bhasinme@nukulb.com Subject: Re: [BB10-Webworks-Packager] As a WebWorks developer, I can enable the flash plug-in for my application to render flash content (#166)

The only problem is that isn't standard ;)

I do agree it fits better there than as rim:enableFlash

Reply to this email directly or view it on GitHub: https://github.com/blackberry/BB10-Webworks-Packager/issues/166#issuecomment-7588572

nukulb commented 12 years ago

@kwallis - ping !!!

kwallis commented 12 years ago

Did we resolve whether this will actually be enabled/disabled based on access elements? Or is it app wide?

nukulb commented 12 years ago

Once its loaded its loaded So cannot enable disable

kwallis commented 12 years ago

Description updated based on design discussions

blackberry / BB10-Webworks-Packager

As a WebWorks developer, I can enable the flash plug-in for my application to render flash content #166

Acceptance Criteria