search

blackberry / BB10-Webworks-Packager

The BB10 WebWorks Packager bundles the App content with the BB10 WebWorks Framework to create a BAR to run on the BB10 Device (or simulator)
27 stars 18 forks source link

As a WebWorks developer, I can specify options for handling initial applicaiton loading and page transition rendering. #182

Closed kwallis closed 12 years ago

kwallis commented 12 years ago

Acceptance Criteria

kwallis commented 12 years ago

cc @EricLeiLi @nukulb @cdelcol Please comment on the current proposal.

kwallis commented 12 years ago

Also, @EricLeiLi, can you provide an estimate on delivery into a build that can be tested?

EricLeiLi commented 12 years ago

I estimated it can be tested by the beginning of Monday or maybe the afternoon of Friday. However, I think @nukulb and @cdelcol suggest a "feature" way to specify the background color.

kwallis commented 12 years ago

It isn't really a \ in how the widget spec describes them. The other thought was to leverage rim:splash, but that doesn't really work since we don't have a parent element for the splashscreens.

I couldn't think of any other existing element to attach this to that made sense, hence creating a new element.

Ken Wallis

Product Manager – BlackBerry WebWorks

Research In Motion

(905) 629-4746 x14369

From: Lei Li [notifications@github.com] Sent: Thursday, September 06, 2012 1:23 PM To: blackberry/BB10-Webworks-Packager Cc: Ken Wallis Subject: Re: [BB10-Webworks-Packager] As a WebWorks developer, I can specify options for handling initial applicaiton loading and page transition rendering. (#182)

I estimated it can be tested by the beginning of Monday or maybe the afternoon of Friday. However, I think @nukulbhttps://github.com/nukulb and @cdelcolhttps://github.com/cdelcol suggest a "feature" way to specify the background color.

— Reply to this email directly or view it on GitHubhttps://github.com/blackberry/BB10-Webworks-Packager/issues/182#issuecomment-8340258.

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

nukulb commented 12 years ago

its background color of the webview at runtime so I think its a feature and you pass it a background color. Its a runtime component that we can control with every URI so how is orientation, flash and stringPatternMatching a feature and background is not

"A feature is a URI identifiable runtime component (e.g. an Application Programming Interface or video decoder). The act of a an author requesting the availability of a feature through a feature element is referred to as a feature request. "

nukulb commented 12 years ago

what does "ready to display" mean

kwallis commented 12 years ago

flash and stringPatternMatching are runtime components that need to be linked in and run etc. I was never fully convinced on orientation really as well, but it was sort of an outlier. Why isn't splashscreen a feature then? The W3C group doesn't consider it a feature as they are proposing the new element .

Ken Wallis

Product Manager – BlackBerry WebWorks

Research In Motion

(905) 629-4746 x14369

From: Nukul Bhasin [notifications@github.com] Sent: Thursday, September 06, 2012 2:11 PM To: blackberry/BB10-Webworks-Packager Cc: Ken Wallis Subject: Re: [BB10-Webworks-Packager] As a WebWorks developer, I can specify options for handling initial applicaiton loading and page transition rendering. (#182)

what does "ready to display" mean

— Reply to this email directly or view it on GitHubhttps://github.com/blackberry/BB10-Webworks-Packager/issues/182#issuecomment-8341795.

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

EricLeiLi commented 12 years ago

I understand "ready to display" means the WebView initialization is done and it is ready to render the new page. That's pretty matched with the meaning of "LocationChange" event of our WebView: which happens just before rendering the content.

kwallis commented 12 years ago

Description updated based on design call.

EricLeiLi commented 12 years ago

In Orientation case, the feature id is "blackberry.app.orientation". For backgroundColor, I need a confirmation whether it's "blackberry.app" or "blackberry.app.backgroundColor", as the implementation will be a lot different.

kwallis commented 12 years ago

Blackberry.app for background color

From: Lei Li [mailto:notifications@github.com] Sent: Thursday, September 06, 2012 04:27 PM To: blackberry/BB10-Webworks-Packager BB10-Webworks-Packager@noreply.github.com Cc: Ken Wallis Subject: Re: [BB10-Webworks-Packager] As a WebWorks developer, I can specify options for handling initial applicaiton loading and page transition rendering. (#182)

In Orientation case, the feature id is "blackberry.app.orientation". For backgroundColor, I need a confirmation whether it's "blackberry.app" or "blackberry.app.backgroundColor", as the implementation will be a lot different.

— Reply to this email directly or view it on GitHubhttps://github.com/blackberry/BB10-Webworks-Packager/issues/182#issuecomment-8346201.

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

jamesjhedley commented 12 years ago

@kwallis For orientation are we still keeping the ID as blackberry.app.orientation? Seems like we should keep the way we handle orientation and backgroundColor consistant with another. I.e. have both defined via blackberry.app but specified as a parameter.

I vote we make it look something like this. Thoughts?

`

portrait 
    <backgroundColor>0xffffff</backgroundColor>
</feature>`
nukulb commented 12 years ago

No orientation will have api later and will need its own namespace.

~Nukul

From: James Keshavarzi [mailto:notifications@github.com] Sent: Thursday, September 06, 2012 05:34 PM To: blackberry/BB10-Webworks-Packager BB10-Webworks-Packager@noreply.github.com Cc: Nukul Bhasin Subject: Re: [BB10-Webworks-Packager] As a WebWorks developer, I can specify options for handling initial applicaiton loading and page transition rendering. (#182)

@kwallishttps://github.com/kwallis For orientation are we still keeping the ID as blackberry.app.orientation? Seems like we should keep the way we handle orientation and backgroundColor consistant with another. I.e. have both defined via blackberry.app but specified as a parameter.

I vote we make it look something like this. Thoughts?

portrait 0xffffff

— Reply to this email directly or view it on GitHubhttps://github.com/blackberry/BB10-Webworks-Packager/issues/182#issuecomment-8348467.

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

jamesjhedley commented 12 years ago

Ok understood. Can we at least get rid of this "param" child element and just specify the params themselves as children? It's much more XML friendly :).

`

0xffffff

`

or we could even do

<feature id="blackberry.app" backgroundColor="0xffffff" />

nukulb commented 12 years ago

Absolutely not its the w3c spec. http://www.w3.org/TR/widgets/#the-feature-element-and-its-attributes

From: James Keshavarzi notifications@github.com<mailto:notifications@github.com> Reply-To: blackberry/BB10-Webworks-Packager reply@reply.github.com<mailto:reply@reply.github.com> Date: Thu, 6 Sep 2012 15:03:31 -0700 To: blackberry/BB10-Webworks-Packager BB10-Webworks-Packager@noreply.github.com<mailto:BB10-Webworks-Packager@noreply.github.com> Cc: Nukul Bhasin nbhasin@rim.com<mailto:nbhasin@rim.com> Subject: Re: [BB10-Webworks-Packager] As a WebWorks developer, I can specify options for handling initial applicaiton loading and page transition rendering. (#182)

Ok understood. Can we at least get rid of this "param" child element and just specify the params themselves as children? It's much more XML friendly :).

0xffffff

or we could even do

— Reply to this email directly or view it on GitHubhttps://github.com/blackberry/BB10-Webworks-Packager/issues/182#issuecomment-8349304.

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

EricLeiLi commented 12 years ago

In <param name="backgroundColor" value="0xffffff">, the correct value that is expected by webview.js interface is a Number, not a String; if a string passed, it won't do anything. So I suppose the correct config.xml line should be <param name="backgroundColor" value=0xffffff> Cheers.

jamesjhedley commented 12 years ago

@kwallis @nukulb Can someone please confirm if the value should be a number so i can make the change in the config-parser.

EricLeiLi commented 12 years ago

Okay, false alarm, <param name="backgroundColor" value=0xffffff> is not correct xml syntax, so we will stick to string value and will do the parsing in packager.

ghost commented 12 years ago

@kwallis @nukulb @jkeshavarzi @EricLeiLi Just curious why the element isn't used for this functionality? (doc'd here: http://wbt20ykf/html5/documentation/rim_loadingscreen_element_834680_11.html)

kwallis commented 12 years ago

The loadingscreen element was used for the splashscreen in previous versions, background colour was just an additional attribute. For BB10 we moved to rim:splash for splashscreen definition, so no need for rim:loadingscreen, and don't want to use it just for background colour. Finally, background colour could in the future be exposed in the API, and having it as a param on the API makes some sense.

Ken Wallis

Product Manager – BlackBerry WebWorks

Research In Motion

(905) 629-4746 x14369

From: Barb Paduch [notifications@github.com] Sent: Wednesday, September 12, 2012 12:08 PM To: blackberry/BB10-Webworks-Packager Cc: Ken Wallis Subject: Re: [BB10-Webworks-Packager] As a WebWorks developer, I can specify options for handling initial applicaiton loading and page transition rendering. (#182)

@kwallishttps://github.com/kwallis @nukulbhttps://github.com/nukulb @jkeshavarzihttps://github.com/jkeshavarzi @EricLeiLihttps://github.com/EricLeiLi Just curious why the element isn't used for this functionality? (doc'd here: http://wbt20ykf/html5/documentation/rim_loadingscreen_element_834680_11.html)

— Reply to this email directly or view it on GitHubhttps://github.com/blackberry/BB10-Webworks-Packager/issues/182#issuecomment-8499556.

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

cdelcol commented 12 years ago

Putting it where we did allows us to expand with future functionality plans, and is also aligned with the W3C which is one of our goals.