search

blackberry / BB10-Webworks-Packager

The BB10 WebWorks Packager bundles the App content with the BB10 WebWorks Framework to create a BAR to run on the BB10 Device (or simulator)
27 stars 18 forks source link

App id should allow for reverse DNS style #183

Closed cdelcol closed 12 years ago

cdelcol commented 12 years ago

currently, it seems like an id with "." is rejected by the packager. The recommended app id is actually reverse DNS, and is mandated for internally built apps.

nukulb commented 12 years ago

I will get it into the next release , should be a quick fix

~Nukul

From: Chris DelCol (RIM) [mailto:notifications@github.com] Sent: Thursday, September 06, 2012 05:22 PM To: blackberry/BB10-Webworks-Packager BB10-Webworks-Packager@noreply.github.com Subject: [BB10-Webworks-Packager] App id should allow for reverse DNS style (#183)

currently, it seems like an id with "." is rejected by the packager. The recommended app id is actually reverse DNS, and is mandated for internally built apps.

— Reply to this email directly or view it on GitHubhttps://github.com/blackberry/BB10-Webworks-Packager/issues/183.

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

rwmtse commented 12 years ago

If I let the BAR packager catch the invalid value, the message that the user gets is: [INFO] MANIFEST.MF net.rim.tools.bar.ManifestException: Invalid value '_pimCalendarTest' for attribute 'Package-Name'.

rwmtse commented 12 years ago

I think this message is too unfriendly. I'd rather we do the check ourselves. Is that ok? @nukulb

jeffheifetz commented 12 years ago

On the other hand, if we leave it its consistent with the NDK so it'll be easier for a developer to figure out what went wrong.

rwmtse commented 12 years ago

Noted. Just doing a straight pass-through now.