search

blackberry / BB10-Webworks-Packager

The BB10 WebWorks Packager bundles the App content with the BB10 WebWorks Framework to create a BAR to run on the BB10 Device (or simulator)
27 stars 18 forks source link

Packager needs to support a syntax to allow system properties. #194

Closed jeffheifetz closed 11 years ago

jeffheifetz commented 11 years ago

The push permission is now a system permission, which means it needs to go into a different place from the normal permission elements in the bar_descriptor.xml.

One possible syntax could be <rim:permit system="true">_sys_use_consumer_push</rim:permit>

kwallis commented 11 years ago

I can't see at this moment if there is any reason that the dev needs to know the difference between system permissions and not? If there is no real reason, can we hide this in some way?

jeffheifetz commented 11 years ago

I would disagree. In every other development platform the dev has to differentiate between system and other permissions, so its something they do have to be aware of.

Besides, to hide this we would need to maintain some sort of list saying which permissions are system ones and which aren't. I would vote against this for the same reason we allow all permissions as direct pass throughs.

nukulb commented 11 years ago

I strongly agree with jeff

We should improve our pass through parameters to be genetic though ~Nukul

kwallis commented 11 years ago

Because other platforms do it is not a reason for our developers to need to know about it.

What I am asking is, what direct or indirect differences between the two types is there? In developer or end-user experience, what are the differences that make it relevant for the developer to know the difference?

jeffheifetz commented 11 years ago

@kwallis I agree with you about other platforms not being our guide, I just think there's no practicaly way to hide such things in general. For the push case we can obviously inject this permission when they add the push API. I just think we need a generic pass through as @nukulb suggests.

nukulb commented 11 years ago

Cannot keep doing this everytime

Maintainability nightmare ~Nukul

From: Jeffrey Heifetz [mailto:notifications@github.com] Sent: Friday, September 28, 2012 10:57 AM To: blackberry/BB10-Webworks-Packager BB10-Webworks-Packager@noreply.github.com Cc: Nukul Bhasin Subject: Re: [BB10-Webworks-Packager] Packager needs to support a syntax to allow system properties. (#194)

@kwallishttps://github.com/kwallis I agree with you about other platforms not being our guide, I just think there's no practicaly way to hide such things in general. For the push case we can obviously inject this permission when they add the push API. I just think we need a generic pass through as @nukulbhttps://github.com/nukulb suggests.

— Reply to this email directly or view it on GitHubhttps://github.com/blackberry/BB10-Webworks-Packager/issues/194#issuecomment-8985480.

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

kwallis commented 11 years ago

We are looking to add complexity to our user and we can't give any reason that matters to them. That is not an easy sell.

From: Nukul Bhasin [mailto:notifications@github.com] Sent: Friday, September 28, 2012 11:00 AM To: blackberry/BB10-Webworks-Packager BB10-Webworks-Packager@noreply.github.com Cc: Ken Wallis Subject: Re: [BB10-Webworks-Packager] Packager needs to support a syntax to allow system properties. (#194)

Cannot keep doing this everytime

Maintainability nightmare ~Nukul

From: Jeffrey Heifetz [mailto:notifications@github.com] Sent: Friday, September 28, 2012 10:57 AM To: blackberry/BB10-Webworks-Packager BB10-Webworks-Packager@noreply.github.com Cc: Nukul Bhasin Subject: Re: [BB10-Webworks-Packager] Packager needs to support a syntax to allow system properties. (#194)

@kwallishttps://github.com/kwallis I agree with you about other platforms not being our guide, I just think there's no practicaly way to hide such things in general. For the push case we can obviously inject this permission when they add the push API. I just think we need a generic pass through as @nukulbhttps://github.com/nukulb suggests.

— Reply to this email directly or view it on GitHubhttps://github.com/blackberry/BB10-Webworks-Packager/issues/194#issuecomment-8985480.

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

— Reply to this email directly or view it on GitHubhttps://github.com/blackberry/BB10-Webworks-Packager/issues/194#issuecomment-8985586.

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

mdandrea commented 11 years ago

Unfortunately, we seem to need a solution for this rather quickly. They're changing the permissions for push so that apps on trunk will not work without this system permission. This will be happening within the next couple of days. System permissions are not too prevalent right now, but there might be new ones added in the future so there has to be a convenient way to support new ones without having to make a code change to the packager each time.

kwallis commented 11 years ago

I am fine proceeding with this, even though I don't like it. ;)

Just puts that much more emphasis on needing tooling around config.xml

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

mdandrea commented 11 years ago

Hey guys, just following up on this. As of trunk OS build 2472 (Thurs at 1:22 pm), push for WebWorks is broken. Adding system permission support to config.xml is the fix for it. Any ideas when this can be added?
Thanks, Matt

nukulb commented 11 years ago

Priortized for this week ~Nukul

From: Matthew D'Andrea [mailto:notifications@github.com] Sent: Monday, October 01, 2012 12:02 PM To: blackberry/BB10-Webworks-Packager BB10-Webworks-Packager@noreply.github.com Cc: Nukul Bhasin Subject: Re: [BB10-Webworks-Packager] Packager needs to support a syntax to allow system properties. (#194)

Hey guys, just following up on this. As of trunk OS build 2472 (Thurs at 1:22 pm), push for WebWorks is broken. Adding system permission support to config.xml is the fix for it. Any ideas when this can be added?

Thanks, Matt

— Reply to this email directly or view it on GitHubhttps://github.com/blackberry/BB10-Webworks-Packager/issues/194#issuecomment-9038087.

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

mdandrea commented 11 years ago

Great, thank you!

ericpearson commented 11 years ago

fixed, can be closed