Open gtanner opened 11 years ago
Not the entire configure script is designed for sudo so if they sudo ./configure all the submodule permission on .git also get sudo which is not correct. I agree that its a great place to be currently but I am not sure we have a good solution yet.
From: Gord Tanner notifications@github.com<mailto:notifications@github.com> Reply-To: blackberry/BB10-Webworks-Packager reply@reply.github.com<mailto:reply@reply.github.com> Date: Thu, 29 Nov 2012 10:42:30 -0800 To: blackberry/BB10-Webworks-Packager BB10-Webworks-Packager@noreply.github.com<mailto:BB10-Webworks-Packager@noreply.github.com> Subject: [BB10-Webworks-Packager] configure script shouldn't use sudo (#222)
If the person needs to sudo to install global modules they should run:
sudo ./configure
Not everyone needs to run sudo to install global packages and if they do when they just run ./configure it will error out on its own telling them to run it with sudo.
— Reply to this email directly or view it on GitHubhttps://github.com/blackberry/BB10-Webworks-Packager/issues/222.
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
Yeah, we could look at the $NODE_PATH
envvar to see if it contains the user's ID:
echo $NODE_PATH | grep "$(whoami)"
If it does we don't need to sudo to install global modules.
The same problem you described with using sudo
to install the global modules is what I am experiencing on my machine (since I don't need to sudo to install them)
sounds like a good change. +1
cc' @jkeshavarzi for scm impact (if at all)
So if i understand correctly, we will continue to use ./configure
but instead of using sudo to install global packages each and every time; We will check the $NODE_PATH envvar to see if sudo is even necessary.
If this is what we want to do, we should update the issue description.
Not 100% sure if this would affect SCM. They setup their builds pretty weird. Each build is run from an isolated virtual drive.
If the person needs to sudo to install global modules they should run:
Not everyone needs to run sudo to install global packages and if they do when they just run
./configure
it will error out on its own telling them to run it with sudo.