search

blackberry / BB10-Webworks-Packager

The BB10 WebWorks Packager bundles the App content with the BB10 WebWorks Framework to create a BAR to run on the BB10 Device (or simulator)
27 stars 18 forks source link

Added support for theme in config.xml #225

Closed tohman closed 11 years ago

tohman commented 11 years ago

Implements issue # blackberry/BB10-Webworks-Packager#206

Set theme for the application controls base one of the values: 'dark', 'default', 'bright', 'inherit'. If no value set or the value spelled wrong, 'default' would be used.

Note: This feature is NOT for R9E.

More info about the feature

jamesjhedley commented 11 years ago

Needs more tests.

tohman commented 11 years ago

@jkeshavarzi, I added more tests. As for the case sensitivity, we better have same approach for all attributes to eliminate confusion.

jamesjhedley commented 11 years ago

Looks good! r+

jamesjhedley commented 11 years ago

Need a working build though. Looks like there are some lint errors.

tohman commented 11 years ago

The code style is inconsistent for parsing the config this is why it's not clear what to follow (e.gIn some places it checks for type some don't same for lowercasing the strings and throwing exceptions when value is not valid). I'll add type check and lowercase as it seem we are moving toward this style if I look at the new addition for websecurity.

Locally I see no lint errors on this branch, I'll rebase with recent next and fpush.

bryanhiggins commented 11 years ago

Tested and merged manually