Closed EricLeiLi closed 11 years ago
@jkeshavarzi r+ routine please.
@tracyli Test please.
How to test: 1.Everything still works: Run packager with "-s" as usual, it should generate bar-descriptor.xml and the bar is generated correctly
2."--appdesc" works: copy the bar-descriptor.xml generated in the first step to another place and do some trivial change to it, then run packager with "--appdesc path_to_bar_descriptor_file", it should NOT generate bar-descriptor.xml BUT use the file we specified. To verify it, you can check for the change you made to it.
3.Packager validates appdesc Run packager with "--appdesc" but with a non-existing file path, the packager should terminate and throw an exception "The bar descriptor file does not exist at the path specified".
r+
FYI, CI build failed.
Needs to be rebased
Rebased with "next". Please test. @tracyli or @jeffheifetz Thanks.
Its time to get this merged, @jkeshavarzi can I get you test this so that we can start merging this after the current release is finalized (hopefully today)
@tracyli is going to test it. No CI build though...
@jkeshavarzi @tracyli CI passed... Please.
tested in windows and mac with http://ci0000003863287:8080/hudson/job/BB10-Webworks-Packager-next-ericli-barxml/2/: --appdesc works as expected and smoke test got passed.
@nukulb ready to be merged.
merged manually
To satisfy build and release, we need to use an existing bar-descriptor.xml instead of generating it. So I add "--appdesc path_to_bar_descriptor_file" to bbwp command. It is only for internal (B&R) use.
Fixes: https://github.com/blackberry/BB10-Webworks-Packager/issues/220
Reviewed by @jkeshavarzi Tested by @tracyli