search

blackberry / BB10-Webworks-Packager

The BB10 WebWorks Packager bundles the App content with the BB10 WebWorks Framework to create a BAR to run on the BB10 Device (or simulator)
27 stars 18 forks source link

Added implementation to support specifying the bar descriptor path in command line #226

Closed EricLeiLi closed 11 years ago

EricLeiLi commented 11 years ago

To satisfy build and release, we need to use an existing bar-descriptor.xml instead of generating it. So I add "--appdesc path_to_bar_descriptor_file" to bbwp command. It is only for internal (B&R) use.

Fixes: https://github.com/blackberry/BB10-Webworks-Packager/issues/220

Reviewed by @jkeshavarzi Tested by @tracyli

EricLeiLi commented 11 years ago

@jkeshavarzi r+ routine please.

EricLeiLi commented 11 years ago

@tracyli Test please.

How to test: 1.Everything still works: Run packager with "-s" as usual, it should generate bar-descriptor.xml and the bar is generated correctly

2."--appdesc" works: copy the bar-descriptor.xml generated in the first step to another place and do some trivial change to it, then run packager with "--appdesc path_to_bar_descriptor_file", it should NOT generate bar-descriptor.xml BUT use the file we specified. To verify it, you can check for the change you made to it.

3.Packager validates appdesc Run packager with "--appdesc" but with a non-existing file path, the packager should terminate and throw an exception "The bar descriptor file does not exist at the path specified".

jamesjhedley commented 11 years ago

r+

jamesjhedley commented 11 years ago

FYI, CI build failed.

jeffheifetz commented 11 years ago

Needs to be rebased

EricLeiLi commented 11 years ago

Rebased with "next". Please test. @tracyli or @jeffheifetz Thanks.

nukulb commented 11 years ago

Its time to get this merged, @jkeshavarzi can I get you test this so that we can start merging this after the current release is finalized (hopefully today)

jamesjhedley commented 11 years ago

@tracyli is going to test it. No CI build though...

EricLeiLi commented 11 years ago

@jkeshavarzi @tracyli CI passed... Please.

tracyli commented 11 years ago

tested in windows and mac with http://ci0000003863287:8080/hudson/job/BB10-Webworks-Packager-next-ericli-barxml/2/: --appdesc works as expected and smoke test got passed.

EricLeiLi commented 11 years ago

@nukulb ready to be merged.

nukulb commented 11 years ago

merged manually