search

blackberry / BB10-Webworks-Packager

The BB10 WebWorks Packager bundles the App content with the BB10 WebWorks Framework to create a BAR to run on the BB10 Device (or simulator)
27 stars 18 forks source link

Implemented --disableAlert to disable web inspector popup on app launch in debug mode. #232

Closed jamesjhedley closed 11 years ago

jamesjhedley commented 11 years ago

When calling bbwp, one can now provide a --disableAlert param to disable the "Web Inspector Enabled" popup that shows when their app is in debug mode.

Framework pull request - https://github.com/blackberry/BB10-WebWorks-Framework/pull/435

jamesjhedley commented 11 years ago

If we don't want to expose --disableAlert, i can remove it from cmdline.js and handle it separately.

jamesjhedley commented 11 years ago

@nukulb @kwallis I shall let you decide if we want to keep this. Didn't take long to write up. Personally i think it's useful to have this option. If i remember correctly, Nukul ran into an issue the other day where he could've benefited from having the alert disabled. I also recall hearing from a few people that they would like the option to disable it.

nukulb commented 11 years ago

agreed that I could have benefitted from this however, disablealert is one really limiting property that never be enhanced. What I really wanted was not to disable alert but rather to not be -d but still enable webinspector :)

so shall we consider --webinspector instead?

disablealert is really limiting property I feel

nukulb commented 11 years ago

leave it up as a pull request and we will see if anyone from the community says +1 if someone has any interest

I don't think this is a feature that is necessary needed for the product

nukulb commented 11 years ago

Shall you rebase?

nukulb commented 11 years ago

closing as we don't want to support this