Closed jamesjhedley closed 11 years ago
Rebased and double checked no new exists
and existsSync
calls need to be refactored.
tested in windows and mac with packager build http://ci0000003863287:8080/hudson/job/BB10-Webworks-Packager-next-node-0.8.14/4/ and framework build http://ci0000003863287:8080/hudson/job/BB10-Webworks-Framework-next-node-0.8.14/2/: configure & jake work well with node0.8.14; automated functional test got passed for all test cases(one known issue for calendar). please note: workaround method was used for windows since jake deploy-test doesn't work in windows due to a known issue.
Please rebase and remove unneeded references to path and I will review again
jake test output is dirty
Looks like a deprecated path.existsSync call snuck in during the rebase. That's why jake test output is dirty. I will fix it.
All changes addressed @jeffheifetz . r+?
merged manually
Node v0.8.14 support -Updated Wrench to 1.3.9 -Updated Windows/Mac node binaries to v0.8.14
Refactored code -path.existsSync --> fs.existsSync -path.exists --> fs.exists
When testing, please do a full regression.
Old blackberry-webworks pull req - https://github.com/blackberry-webworks/BB10-Webworks-Packager/pull/106