search

blackberry / BB10-Webworks-Packager

The BB10 WebWorks Packager bundles the App content with the BB10 WebWorks Framework to create a BAR to run on the BB10 Device (or simulator)
27 stars 18 forks source link

Fixed the missing fs.copySync patch in native-packager.js #240

Closed EricLeiLi closed 11 years ago

EricLeiLi commented 11 years ago

fs.copySync is deprecated in node 0.8.14 and we all changed it to packagerUtils.copyFile. However, the location (for appdesc use case) is missing in native-packager.js, we need to fix it.

Fixes blackberry/BB10-Webworks-Packager#239

Reviewed By: @jkeshavarzi Tested By: @tracyli

EricLeiLi commented 11 years ago

@jkeshavarzi review please

jamesjhedley commented 11 years ago

r+

nukulb commented 11 years ago

lint error

lib/native-packager.js: line 64, col 9, 'packagerUtils' is not defined.

1 error

lib/native-packager.js : Implied globals: packagerUtils: 64

EricLeiLi commented 11 years ago

Fixed lint, now testing.

EricLeiLi commented 11 years ago

Jake test and lint passed; werified with CI/BB10-Webworks-Packager-next-ericli-fix-fsCopySync/4/, --appdesc works as expected. @nukulb Merge please.

nukulb commented 11 years ago

merged