Adding isNull and isEmpty validation checks for ID field.

blackberry / BB10-Webworks-Packager

The BB10 WebWorks Packager bundles the App content with the BB10 WebWorks Framework to create a BAR to run on the BB10 Device (or simulator)

27 stars 18 forks source link

Closed jamesjhedley closed 11 years ago

jamesjhedley commented 11 years ago

Fixes blackberry/BB10-Webworks-Packager#246

To test, simply package an application with no id set or set to an empty string and ensure the Packager throws an error.

jamesjhedley commented 11 years ago

@rwmtse Code review?

rwmtse commented 11 years ago

Looks good, r+

jeffheifetz commented 11 years ago

@jkeshavarzi please advise what testing needs to be done. Also it appears that there is an extra commit here

jamesjhedley commented 11 years ago

Rebased + fixed extra commit. See description for how to test.

tracyli commented 11 years ago

tested for Windows and Max in 10.0.10.345 with packager build http://wwci:8080/view/BB10-WebWorks-Packager/view/Jobs/job/BB10-Webworks-Packager-next-fix246/9/: 1.automatic test app got passed(one known issue for pim.calendar)

Error message "Please enter an application id" was provided as expected when packaging an app without id or with empty id

jeffheifetz commented 11 years ago

Merged Manually